Skip to content

FIX: Backport #826 to 2.5.x #827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 16, 2019
Merged

FIX: Backport #826 to 2.5.x #827

merged 2 commits into from
Oct 16, 2019

Conversation

effigies
Copy link
Member

@effigies effigies changed the base branch from master to maint/2.5.x October 16, 2019 00:17
@codecov
Copy link

codecov bot commented Oct 16, 2019 •
edited
Loading

Codecov Report

Merging #827 into maint/2.5.x will decrease coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@               Coverage Diff               @@
##           maint/2.5.x     #827      +/-   ##
===============================================
- Coverage        89.99%   89.95%   -0.05%     
===============================================
  Files               95       95              
  Lines            12049    12049              
  Branches          2143     2143              
===============================================
- Hits             10844    10839       -5     
- Misses             857      863       +6     
+ Partials           348      347       -1
Impacted Files Coverage Δ
nibabel/funcs.py 80.55% <ø> (ø) ⬆️
nibabel/openers.py 81.45% <ø> (ø) ⬆️
nibabel/fileholders.py 93.1% <ø> (ø) ⬆️
nibabel/loadsave.py 90.47% <ø> (ø) ⬆️
nibabel/streamlines/__init__.py 100% <ø> (ø) ⬆️
nibabel/arraywriters.py 96.93% <ø> (ø) ⬆️
nibabel/streamlines/tractogram.py 99.66% <ø> (ø) ⬆️
nibabel/brikhead.py 97.48% <100%> (ø) ⬆️
nibabel/deprecator.py 100% <100%> (ø) ⬆️
nibabel/pydicom_compat.py 77.27% <0%> (-22.73%) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b1fa66...ddab546. Read the comment docs.

@effigies effigies merged commit 3cbef01 into maint/2.5.x Oct 16, 2019
@effigies effigies deleted the backport-826 branch October 16, 2019 22:04
@effigies effigies modified the milestone: 3.0.0 Oct 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@effigies @larsoner